[S] Change in osmo-msc[master]: libsmpputil: fix -Wtautological-constant-out-of-range-compare
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email ) Change subject: libsmpputil: fix -Wtautological-constant-out-of-range-compare ...................................................................... libsmpputil: fix -Wtautological-constant-out-of-range-compare * 'sizeof(sms->user_data)' evaluates to 256 * 'ud_len' is of type 'uint8_t' and cannot be greater than 256 Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed --- M src/libsmpputil/smpp_msc.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/35966/1 diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c index cf17540..0c2a928 100644 --- a/src/libsmpputil/smpp_msc.c +++ b/src/libsmpputil/smpp_msc.c @@ -241,7 +241,7 @@ } if (mode == MODE_7BIT) { - uint8_t ud_len = 0, padbits = 0; + unsigned int ud_len = 0, padbits = 0; sms->data_coding_scheme = GSM338_DCS_1111_7BIT; if (sms->ud_hdr_ind) { ud_len = *sms_msg + 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed Gerrit-Change-Number: 35966 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: newchange
participants (1)
-
fixeria