laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31410 ) Change subject: hnbgw: f_iuh2iu_disconnect: allow more time ...................................................................... hnbgw: f_iuh2iu_disconnect: allow more time Increase timeout for expecting an SCCP RLSD from osmo-hnbgw. Affects tests HNBGW_Tests.TC_ranap_cs_mo_disconnect HNBGW_Tests.TC_ranap_ps_mo_disconnect Rationale: For the case RUA --id-Disconnect--> HNBGW ----release-SCCP---- CN the tests expect behavior not exactly specified. 3GPP TS 48.006 9.2 Connection release: The MSC sends a SCCP released message. This message shall not contain any user data field. So what we should expect is this: HNBGW MSC RUA --id-Disconnect-------> | ---Data-Form-1(!)---> | Iu-ReleaseComplete | <--Released---------- | (no data) Instead, we expect the HNBGW to immediately send a RLSD to the MSC: HNBGW MSC RUA --id-Disconnect-------> | ---Released---------> | Iu-ReleaseComplete osmo-hnbgw is being fixed in that respect: it will soon give time for the CN to send an SCCP RLSD, and only if that times out will osmo-hnbgw send an SCCP RLSD to the CN. So HNBGW_Tests.ttcn should still ensure that osmo-hnbgw will eventually send an SCCP RLSD if the CN fails to do so, but it should allow more time to accomodate the release timeout. Related: osmo-hnbgw I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Related: SYS#6297 Change-Id: Ibf6eaeb1b82d43e4f208f64a71f2f6e889883a11 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 63 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2aa6407..5a2c72e 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -561,11 +561,25 @@ return rx; } +/* 3GPP TS 48.006 9.2 Connection release: + * + * The MSC sends a SCCP released message. This message shall not contain + * any user data field. + * + * So what we expect normally is: + * + * HNBGW MSC + * RUA --id-Disconnect-------> | ---Data-Form-1(!)---> | Iu-ReleaseComplete + * | <--Released---------- | (no data) + * + * This function tests osmo-hnbgw behavior if the CN fails to send a RLSD: + * after some timeout, osmo-hnbgw should send a RLSD to the CN. + */ function f_iuh2iu_disconnect(template (present) RANAP_PDU tx, RUA_IEs.Cause cause, template RANAP_PDU exp_rx := omit) runs on ConnHdlr return RANAP_PDU { var RANAP_PDU rx - timer T := 5.0; + timer T := 10.0; if (istemplatekind(exp_rx, "omit")) { exp_rx := tx; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf6eaeb1b82d43e4f208f64a71f2f6e889883a11 Gerrit-Change-Number: 31410 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged