lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42601?usp=email )
Change subject: rspro_server: don't access the msg on error cases ......................................................................
rspro_server: don't access the msg on error cases
The msg is NULL on errors.
Related: SYS#7930 Change-Id: I4e95c2473acd72cd2e01df329691c8f31882b3d9 --- M src/server/rspro_server.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/01/42601/1
diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 70d59c1..ac10cad 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -712,7 +712,7 @@ /* data was received from one of the client connections to the RSPRO socket */ static int sock_read_cb(struct osmo_stream_srv *peer, int res, struct msgb *msg) { - enum ipaccess_proto ipa_proto = osmo_ipa_msgb_cb_proto(msg); + enum ipaccess_proto ipa_proto; struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); RsproPDU_t *pdu; int rc; @@ -722,6 +722,9 @@ goto err; }
+ ipa_proto = osmo_ipa_msgb_cb_proto(msg); + conn = osmo_stream_srv_get_data(peer); + switch (ipa_proto) { case IPAC_PROTO_IPACCESS: rc = _ipa_srv_conn_ccm(conn, msg);