Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33953 ) Change subject: Added calls to stub decryption functions for MAC resources ...................................................................... Patch Set 1: (4 comments) File src/tetra_upper_mac.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10084): https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/b090459d_6315da51 PS1, Line 207: if (!rsd.is_encrypted) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10084): https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/f1b80714_d410025f PS1, Line 230: if (rsd.is_encrypted) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10084): https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/cec00a51_4e6c317c PS1, Line 360: if (fragslots[slot].encryption && fragslots[slot].key) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10084): https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/dd779ec2_d8813bd1 PS1, Line 490: if (REASSEMBLE_FRAGMENTS) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I92d718789d6b7e84c1901d09165fce59cdf8c1ca Gerrit-Change-Number: 33953 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 27 Jul 2023 08:28:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment