Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 ) Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/c3774cbc_d882fb5b PS3, Line 10: libosmogsm UPDATE_DEP_VER update libosmogsm version dependency after Ie775fedba4a3fa12314c0f7c8a369662ef6a40df is released fyi libosmogsm > 1.8.0 is more useful to me than having to look at several random change-ids in this file. If I want to get the exact change-id you put there I can always look at the commit adding this line and see the "Depends" line on it. File src/auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/6a145b3b_2d764efb PS3, Line 119: vec[i].res_len = 8; maybe add a NOTICE log message if res_len was not 8, not let the user note that this is missing proper implementation. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2 Gerrit-Change-Number: 33097 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 14 Jun 2023 13:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment