Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email ) Change subject: sccplite: rx mgcp: Make sure payload string is null-terminated ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/osmo_bsc_mgcp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41449/comment/3431d6eb_f40496cf?usp=... : PS2, Line 174: *msg->tail = '\0'; Note that `msgb->len` remains unchanged here. Is it intentional that you're not using `msgb_put_u8(msg, 0)` here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac3ea7dd5d89eb9ffb6d5123700e9dc9cdfc2ea2 Gerrit-Change-Number: 41449 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Fri, 21 Nov 2025 10:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes