Change in osmo-e1d[master]: usb: Use libusb_status_str when logging INT EP error
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26821 ) Change subject: usb: Use libusb_status_str when logging INT EP error ...................................................................... usb: Use libusb_status_str when logging INT EP error Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a --- M src/usb.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/21/26821/1 diff --git a/src/usb.c b/src/usb.c index 7db9994..94cccae 100644 --- a/src/usb.c +++ b/src/usb.c @@ -376,7 +376,8 @@ const struct ice1usb_irq *irq = (const struct ice1usb_irq *) xfer->buffer; if (xfer->status != LIBUSB_TRANSFER_COMPLETED) { - LOGPLI(line, DE1D, LOGL_ERROR, "Error in Interrupt transfer\n"); + LOGPLI(line, DE1D, LOGL_ERROR, "INT EP %02x transfer failed with status %s\n", + xfer->endpoint, get_value_string(libusb_status_str, xfer->status)); goto out; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a Gerrit-Change-Number: 26821 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-MessageType: newchange
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26821 ) Change subject: usb: Use libusb_status_str when logging INT EP error ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a Gerrit-Change-Number: 26821 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Sun, 09 Jan 2022 22:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26821 ) Change subject: usb: Use libusb_status_str when logging INT EP error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a Gerrit-Change-Number: 26821 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Mon, 10 Jan 2022 10:04:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26821 ) Change subject: usb: Use libusb_status_str when logging INT EP error ...................................................................... usb: Use libusb_status_str when logging INT EP error Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a --- M src/usb.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified tnt: Looks good to me, approved diff --git a/src/usb.c b/src/usb.c index 8124f26..0c0afe4 100644 --- a/src/usb.c +++ b/src/usb.c @@ -375,7 +375,8 @@ const struct ice1usb_irq *irq = (const struct ice1usb_irq *) xfer->buffer; if (xfer->status != LIBUSB_TRANSFER_COMPLETED) { - LOGPLI(line, DE1D, LOGL_ERROR, "Error in Interrupt transfer\n"); + LOGPLI(line, DE1D, LOGL_ERROR, "INT EP %02x transfer failed with status %s\n", + xfer->endpoint, get_value_string(libusb_status_str, xfer->status)); goto out; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I3a3cd88ba35796740dbd399eb618617941dae54a Gerrit-Change-Number: 26821 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-MessageType: merged
participants (2)
-
laforge -
tnt