Attention is currently required from: laforge, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31615 ) Change subject: VTY,CTRL: add pchan dynamic/{osmocom,ipaccess} ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: i settled for dynamic/osmocom and dynamic/ipaccess now. One thing to consider for this patch, do we really want to change the pchan names on items returned on the CTRL interface? If not, we need to keep the old names as default, meaning also that a VTY write will replace 'dynamic/osmocom' with 'TCH/F_TCH/H_SDCCH8_PDCH'. I did keep the stat/rate_ctr naming unchanged, to save users having to adjust their stat evaluation to match the naming tweak... there it is still 'OSMO_DYN' and "TCH/F_PDCH' ... so it's completely inconsistent now but backwards compatible. Maybe that's half-arsed and we should rather change to consistent naming everywhere? An argument for changing all naming everywhere is that we already did change the naming when adding SDCCH8 to TCH/F_TCH/H_PDCH, where VTY and CTRL changed to "TCH/F_TCH/H_SDCCH8_PDCH" and stats/rate_ctr changed to "OSMO_DYN", and no-one complained AFAIK. any opinions? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e Gerrit-Change-Number: 31615 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Mar 2023 01:40:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment