[M] Change in osmo-hlr[master]: subscriber-create-on-demand: rework configuration - gerrit-log

10 Aug 2024


      Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email )
Change subject: subscriber-create-on-demand: rework configuration
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: 
nice!
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/37779/comment/d3f7579d_6fdd993e?usp=... :
PS1, Line 300: 		vty_out(vty, " no subscriber-create-on-demand%s", VTY_NEWLINE);
This is the default, I thought we omit these. But you even adjusted the test so you probably did it on purpose. What is the reasoning behind that?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9
Gerrit-Change-Number: 37779
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 07 Aug 2024 10:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes