Attention is currently required from: pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314 ) Change subject: ggsn: Support rx cause 'New PDP type due to network preference' ...................................................................... Patch Set 1: (3 comments) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/10623360_df5e3... PS1, Line 366: if (not match(cpr.endUserAddress, tr_EuaIPv4(?)) and Let's make it shorter: if (not match(cpr.endUserAddress, (tr_EuaIPv4(?), tr_EuaIPv6(?)))) { ... } https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/e6a29ac2_64552... PS1, Line 1704: cause_accept Defined but not used, why? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314/comment/82e91bd1_a7ed8... PS1, Line 1705: var const, here and the line below -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iace6a4bd0c2372601dc43108ec4eb78602dbcf30 Gerrit-Change-Number: 27314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 19:53:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment