dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43920?usp=email )

Change subject: onomondo_eim_app: rename function start_esipa_server ......................................................................

onomondo_eim_app: rename function start_esipa_server

The function name start_esipa_server is misleading, since the same function is also used to start the REST server. Both are HTTP(s) servers, so let's call the function "start_http_server" instead.

Change-Id: Ia8ffded7cdf82ea4a85e2b3708aa6429c4c46996 Related: SYS#8287 --- M src/onomondo_eim_app.erl 1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/20/43920/1

diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index 07a2ed6..a8614d7 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -10,7 +10,7 @@ -export([start/2, esipa_dispatch/0]). -export([stop/1]).

-start_esipa_server(true, Ip, Port, _Cert, _Key, Dispatch, Middlewares, InterfaceName) -> +start_http_server(true, Ip, Port, _Cert, _Key, Dispatch, Middlewares, InterfaceName) -> logger:notice("Starting ~s HTTP server at ~p:~p...~n", [InterfaceName, Ip, Port]), cowboy:start_clear( http_listener_esipa, @@ -25,7 +25,7 @@ middlewares => Middlewares } ); -start_esipa_server(false, Ip, Port, Cert, Key, Dispatch, Middlewares, InterfaceName) -> +start_http_server(false, Ip, Port, Cert, Key, Dispatch, Middlewares, InterfaceName) -> logger:notice( "Starting ~s HTTPs server at ~p:~p...~ncertificate: ~p~nkey: ~p~n", [InterfaceName, Ip, Port, Cert, Key] @@ -114,7 +114,7 @@ {ok, EsipaSslDisable} = application:get_env(onomondo_eim, esipa_ssl_disable), {ok, EsipaSslCert} = utils:get_env_priv_file_path(onomondo_eim, esipa_ssl_cert), {ok, EsipaSslKey} = utils:get_env_priv_file_path(onomondo_eim, esipa_ssl_key), - {ok, _} = start_esipa_server( + {ok, _} = start_http_server( EsipaSslDisable, EsipaIp, EsipaPort, @@ -130,7 +130,7 @@ Dispatch_REST = rest_dispatch(), {ok, RestIp} = application:get_env(onomondo_eim, rest_ip), {ok, RestPort} = application:get_env(onomondo_eim, rest_port), - {ok, _} = start_esipa_server( + {ok, _} = start_http_server( true, RestIp, RestPort,