Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266 ) Change subject: bts: Proper tear down ...................................................................... Patch Set 2: (2 comments) File bts/BTS_Tests_OML.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/a8daf341_6458a... PS1, Line 155: friend

I think you want `private` instead of `friend` here, since this function is not used anywhere outsid […] Not addressed.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/19810e34_81150... PS1, Line 155: f_shutdown_helper

I prefer using a local wrapper so that we don't need to change lots of tests afterwards if more stuf […] Ok then.

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I761ae94aa698a74bb30b8a6b1860358545f222b5 Gerrit-Change-Number: 32266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Apr 2023 14:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment