Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email ) Change subject: Gb: ensure a BSSGP Tx Status don't overflow on too big messages ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/9640d693_5c0b86cf?u... : PS1, Line 11: TS 48.018 specifies the BSSGP layer should taken the lower layer should take File src/gb/gprs_bssgp_util.c: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/14342df9_22685fd2?u... : PS1, Line 587: OSMO_MIN(msgb_bssgp_len(orig_msg), msgb_tailroom(msg) - 3), is the 3 for T + L? Do you mind writing it in a comment? File tests/gb/gprs_bssgp_test.c: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/13f171d0_baa98419?u... : PS1, Line 293: static bool _test_bssgp_tx_status_too_big_rx = false; This variable seems unused, only set to true and nothing more. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I427d23887dcc05705228b553428d14fda086b06f Gerrit-Change-Number: 43890 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 14 Oct 2026 16:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No