pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email ) Change subject: sccp_user: Fix ASP not restarted after associating a new AS to it ...................................................................... sccp_user: Fix ASP not restarted after associating a new AS to it Recent commit introduced a regression when applying default_layer_manager to all ASPs in m3ua-mode ASP. The call to osmo_ss7_asp_restart() was moved to an inner code path but I failed to figure out the ASP restart is also needed in this code path. Fixes: ce63d3b2027cefb8412179497100d14ed3fee0dd Change-Id: I5cccad3347dbea33433028e17571b1c16ecaf719 --- M src/sccp_user.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/sccp_user.c b/src/sccp_user.c index a32bbaa..b869dab 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -634,6 +634,11 @@ LOGP(DLSCCP, LOGL_NOTICE, "%s: ASP %s for %s is not associated with any AS, using it\n", name, asp->cfg.name, osmo_ss7_asp_protocol_name(prot)); ss7_as_add_asp(as, asp); + /* ASP became associated to a new AS, hence it needs to be + * restarted to announce/register its Routing Context. + * Make sure proper defaults are applied if app didn't + * provide specific default values, then restart the ASP: */ + ss7_asp_restart_after_reconfigure(asp); break; } if (!asp) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5cccad3347dbea33433028e17571b1c16ecaf719 Gerrit-Change-Number: 39676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>