Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 4: (3 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/8cd3f6c6_22facbf6 PS3, Line 38: OSMO_SUART_F_BREAK = (1 << 2), So far there was no need to do anything else with those flags other than setting/unsetting and checking them. In the original Harald's code it was actually as you suggested (0, 1, 2), but the code was using them incorrectly, as if they were the actual flags (i.e. without doing 1 << N). So I fixed the problem this way.

Anyway, just saying, if FOO_FIVE == 0x10, it's not so trivial to calculate that back to a 5.)

In the worst case one can use the libc's `ffs()` function. But well, even you cannot remember the actual use case for doing this math :P https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/14be204f_4345560c PS3, Line 52: stop bots

a stop bot, is that a traffic light? =) Haha! Nice one :D Fixed in this patch: https://gerrit.osmocom.org/c/libosmocore/+/35122

File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/c0506d87_99e2c06b PS3, Line 4: * (C) 2022 by Harald Welte <laforge@gnumonks.org>

2022-2023? […] This patch is mostly Harald's original code from 2022 (https://cgit.osmocom.org/libosmocore/commit/?h=laforge/libosmoisdn&id=c776de...) with a small number of cosmetic edits from my side, plus the `OSMO_SUART_F_` fix that I squashed into this patch. The code is further improved and completed in subsequent patches (one of them adding Sysmocom to this header).

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 23 Nov 2023 20:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment