Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email )

Change subject: s1gw: Add initial PFCP support emulating UPF ......................................................................

Patch Set 2:

(3 comments)

File s1gw/ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/998c4ebc_c0b65... : PS2, Line 185: float Tval := 5.0 This looks unrelated. Can you explain why doing this change?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/827366be_dbe0a... : PS2, Line 269: do_repeat := true Do we normally expect receiving the Assoc Setup Req more than once? This would likely mean that the `pfcp_peer` module has crashed...

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/11c9b39c_7d4f4... : PS2, Line 81: id) alive These changes looks unrelated to me:

* adding `alive` -- sounds like a separate patch? * making `id` configurable (but still passing `testcasename()`) * why doing this? what for?