Attention is currently required from: daniel, dexter, fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227?usp=email ) Change subject: hlr: pyhss: create/delete subscribers ...................................................................... Patch Set 2: (1 comment) File library/PyHSS_REST_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227/comment/3da29cef_878d9... : PS2, Line 43: private function f_pyhss_algo(template (omit) charstring algo2g := omit,

In that case, the variable in line 84 would always be set to the algo2g value?

yes

When I look at f_vty_subscr_create() that sets the algorithm for both 2g and 3g, but I don't know how/if that works in pyhss.

In PyHSS, there is [only one algo field](https://github.com/nickvsnetworking/pyhss/blob/572af5012b41f6140a2e01d64984d...), with the following description:

2G Authentication Algorithm (1 = Comp128v1, 2 = Comp128v2, 3 = Comp128v3, All Other= 3G auth with 2g keys from 3G Milenage)

So as I understand it, we can't properly map the "both algo2g and algo 3g are != omit" case to PyHSS. This doesn't affect the outcome of the testcases, so at least initially this should be good enough IMHO. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic924dabbc813459f73d6646ee17b79cb11d39a76 Gerrit-Change-Number: 41227 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Oct 2025 14:25:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>