pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email ) Change subject: vty: Prohibit confiruing an IPA ASP as IPSP ...................................................................... vty: Prohibit confiruing an IPA ASP as IPSP We could eventually define how the IPA CCM is expected to behave when in IPSP role (eg. implementing/allowing both sides of IPA CCM, or assigning an IPA CCM role based on TCP client/server), but that has not yet been defined. IPSP is actually a good candidate for IPA ASPs, since in IPA proto we don't have SNM messaging either, and it's meant to be used point-to-point (or through STP by assigning hardocded routes). Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54 --- M src/ss7_asp_vty.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/71/42071/1 diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 27b7462..6731398 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -423,6 +423,11 @@ vty_out(vty, "IPSP role can't be used in an SG node since they are point-to-point%s", VTY_NEWLINE); return CMD_WARNING; } + if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) { + /* There's no definition yet on how IPA ASPs should behave in IPSP role... */ + vty_out(vty, "IPSP role is not supported in ASP protol 'ipa'%s", VTY_NEWLINE); + return CMD_WARNING; + } asp->cfg.role = OSMO_SS7_ASP_ROLE_IPSP; } else { OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54 Gerrit-Change-Number: 42071 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de>