Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email ) Change subject: RTP: make ortp optional at compile time ...................................................................... Patch Set 2: (3 comments) Patchset: PS2:

I see these 2 ORTP references, but they are probably wrong and can be dropped since they should come […] I will make a follow-up patch removing these bogons. And yes, they are bogons because osmo-bts configure has no pkg-config calls for ortp, only libosmo-abis configure does.

File contrib/ber/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/6cde183d_86b99258?usp=... : PS2, Line 1: if ENABLE_ORTP

See how it's done for instance in osmo-bsc/src/Makefile. […] Will do.

File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/3d7653e4_cb5794d4?usp=... : PS2, Line 406: {

you don't really need {} afaict, we are enforcing -std=gnu11 during build in configure. […] But I prefer to have these braces here, as they keep the local var contained in this block, not accessible outside of it. Initially I just put `#ifdef HAVE_ORTP` around the two original executing-code lines, but then the result was a compiler warning about unused automatic variable when building with `--disable-ortp`. If we remove the braces while keeping the local var declaration inside the `#ifdef`, then subsequent code in this function either sees or not sees this local var depending on ortp build config - not good IMO.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1 Gerrit-Change-Number: 42197 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>