neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )
Change subject: add fmtp string to ptmap: allow all possible fmtp
......................................................................
Patch Set 6: Code-Review-1
(4 comments)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/f23a3aec_9a725e02
PS6, Line 1372: !
==
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/dd0fc1b9_19ab61ee
PS6, Line 1376: octet-align=1
use OSMO_MGCP_AMR_OCTET_ALIGN_EQUALS(1)
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/35cc54c6_06ae9018
PS6, Line 1376: a=fmtp:%u
there should be some def like
#define FOO "a=fmtp:"
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/af9539a1_fd1629a3
PS6, Line 1378: octet
use OSMO_MGCP_AMR_OCTET_ALIGN_EQUALS(0)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Nov 2023 02:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment