Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501?usp=email )

Change subject: pgw: Test v6 and v4v6 PDU session userplane ......................................................................

Patch Set 1:

(8 comments)

File library/GTPv2_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/aaa1d0e8_23c3d... : PS1, Line 391: ts_GTP2C_PdnAddrAlloc

`tr_GTP2C_PdnAddrAlloc` (receive template) - unrelated, to this patch though.

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/31f81e1a_3dc73... : PS1, Line 398: ts_GTP2C_PdnAddrAlloc

`tr_GTP2C_PdnAddrAlloc` (receive template)

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/c8d4e56b_694f0... : PS1, Line 405: ts_GTP2C_PdnAddrAlloc

`tr_GTP2C_PdnAddrAlloc` (receive template)

Done

File pgw/PGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/fac695d4_d69ff... : PS1, Line 703: valueof

`valueof()` is not needed here

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/9b726387_13e2e... : PS1, Line 718: valueof

likewise here, `valueof()` is not needed

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/98a9771b_9f791... : PS1, Line 835: iPv6_Address

copy-pasted, should be `iPv4_IPv6`

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/3f324915_48263... : PS1, Line 837: g_ip4_addr

Do we want to log the assigned IPv4 address like we do above?

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/d4c0715f_060d1... : PS1, Line 988: redirect_output := true, :

unneeded ws changes

Done