[XS] Change in pysim[master]: setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it
Attention is currently required from: dexter, laforge, osmith. osmith has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43981?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by osmith, Verified-1 by Jenkins Builder Change subject: setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it ...................................................................... setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it smpp.twisted3 is imported by pySim-smpp2sim.py alone; no module under pySim/ uses it. Every release of smpp.twisted3 pins Twisted~=23.10.0, a Twisted with three open advisories (CVE-2026-42304, CVE-2024-41810, CVE-2024-41671), so every installation of the library carries a Twisted it never loads and cannot upgrade. Move the requirement to a `smpp2sim` extra; the script keeps working with `pip install "pysim[smpp2sim]"` and fails with a plain ImportError without it, the same way the `smdpp` extra behaves for klein. The folder osmocom-pysim-smpp-twisted-optional of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and the validation output. Co-Authored-By: Oliver Smith <osmith@sysmocom.de> Change-Id: I7001effd073fa341c08a6e4508e22b568aa7cd70 --- M contrib/jenkins.sh M requirements.txt M setup.py 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/43981/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7001effd073fa341c08a6e4508e22b568aa7cd70 Gerrit-Change-Number: 43981 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de>
participants (1)
-
osmith