Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: (2 comments) File src/gsup_client.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/e6702a28_b... PS2, Line 99:

cosmetic: use tabs we need to use an erlang formater. But so far most of the files are mixed between tabs and spaces.

https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/e33345e5_f... PS2, Line 99: Failed to

This sentence looks incomplete: "failed to ..." do what? […] Ack

-- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Thu, 07 Sep 2023 12:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment