laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33828 ) Change subject: ASCI: Add missing check for return value of gsm0808_enc_speech_codec_list2() ...................................................................... ASCI: Add missing check for return value of gsm0808_enc_speech_codec_list2() Fixes: CID#318987 Change-Id: I771b8ee8dfe1588d0af1c4957489f723447a7054 --- M src/gsm/gsm0808.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 6ba6ef2..529dbdf 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -1756,13 +1756,19 @@ msgb_tlv_put(msg, GSM0808_IE_CIRCUIT_POOL_LIST, params->cpl.list_len, params->cpl.pool); /* Codec List (BSS Supported) 3.2.2.103 */ - if (params->codec_list_present) - gsm0808_enc_speech_codec_list2(msg, ¶ms->codec_list_bss_supported); + if (params->codec_list_present) { + if (gsm0808_enc_speech_codec_list2(msg, ¶ms->codec_list_bss_supported) < 0) + goto exit_free; + } /* prepend header with final length */ msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg)); return msg; + +exit_free: + msgb_free(msg); + return NULL; } /*! Create BSSMAP VGCS/VBS QUEUING INDICATION message, 3GPP TS 48.008 3.2.1.56. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I771b8ee8dfe1588d0af1c4957489f723447a7054 Gerrit-Change-Number: 33828 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged