Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email )
Change subject: IPAd: Add test case for multple eIM packages ......................................................................
Patch Set 1:
(2 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/0d71f854_cda65... : PS1, Line 1170: var integer i, rounds := 5;
maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/f6a6d39a_158dc... : PS1, Line 1209: f_init(id, 300.0);
maybe write t_guard := 300.0, than its more obvious what the number means. […]
Done
-
jolly