Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email ) Change subject: stream (test): Fix Coverity CID 323456 ...................................................................... Patch Set 1: (1 comment) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34671/comment/67f9a54b_46126c34 PS1, Line 681: if (5 < ipa_msg_type) {

this syntax for comparision is a bit weird imho. I'd say we usually have the vars on the left side. […] I thought about it, but then I also thought somebody else might complain that leaving it the way it is would make reading the diff more easy, so I left it the way it was.

-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2efb28feae4d4fa7516702f01026af09aa3777ac Gerrit-Change-Number: 34671 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 17:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment