Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email ) Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS ...................................................................... Patch Set 1: (3 comments) File doc/manuals/abis/rsl.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/b3a1fc10_e11a4850 PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <<RSL_IE_OSMO_TEMP_OVP_ACCH_CAP>> These 2 above seem to actually be missing but not really related to this patch, so perhaps submit them separately as a pre-patch we can merge straight away? https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/65b38eb1_4f36bb66 PS1, Line 1097: [[RSL_IE_OSMO_TEMP_OVP_ACCH_CAP]] Same for these 2 above. https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/a2ec53dd_03aea77b PS1, Line 1110: This information element requests the use of non-standard enhanced RTP I'm maybe missing some sort of packetdiag output (see for instance packetdiag examples in ./osmo-bsc/doc/manuals/osmux-reference.adoc), or at least a table here (see eg. line 1084). I think this is imporant since this field seems to be a TLV which may be extended later, so I'm not really sure what's the idea here. Is it for now a bitmask? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Comment-Date: Tue, 07 May 2024 14:34:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment