Attention is currently required from: daniel, laforge, lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email )

Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ......................................................................

Patch Set 6:

(5 comments)

File src/ss7_as_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/3a60ca2b_43d054... : PS4, Line 269: "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n"

Done

This was not addressed.

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/b04c6784_8639eb... : PS4, Line 547: const char *tcap_unroutable_str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals,

No, it is also used by LOAD_SHARE_AS.

Done

File src/tcap_as_loadshare.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/2118246e_474a5c... : PS3, Line 510: rc = -ENOKEY;

Not sure what you mean.

Done

File src/tcap_as_loadshare.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/52379e88_3ff98b... : PS4, Line 478: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or

Done

This was not addressed...

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/50838448_aec5f8... : PS4, Line 506: /* Message is handled and will be routed elsewhere */

afaiu this comment is misleading, since case "rc" is actually an error and the message is not being […]

Done