Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/31120 )
Change subject: trau_pcu_ericsson: fix broken length check
......................................................................
Patch Set 1:
(1 comment)
File src/trau/trau_pcu_ericsson.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31120/comment/8883aca1_3d991ada
PS1, Line 273: if (bits_len < offs)
are you sure this shouldn't be bits_len <= offs? because if bits_len == offs,
whtever you read will already be out of bounds.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31120
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9e0cd5d36c517b9198e0dc1bec0477a2ee2fb869
Gerrit-Change-Number: 31120
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 15:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment