Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/ipa/libipa/es10b_exec_fallback_mech.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/17d88bd5_baec11e4?... : PS3, Line 14: struct ExecuteFallbackMechanismResponse *res; The response is basically just an integer, you could return that integer from ipa_es10b_exec_fallback_mech directly. This would allow you to get rid of ipa_es10b_exec_fallback_mech_res_free and the API would me much simpler.
However, the downside is that there would be less flexibility in case the response struct gets extended.
-
dexter