Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/32162 )
Change subject: mgcp_client: simpler error handling
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5620):
https://gerrit.osmocom.org/c/osmo-mgw/+/32162/comment/5f7e0fdd_ab31ff2d
PS1, Line 1134: #define MSGB_PRINTF_OR_RET(msg, FMT, ARGS...) \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else
logic defects
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/32162
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e
Gerrit-Change-Number: 32162
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 30 Mar 2023 16:30:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment