Change in osmo-e1-hardware[master]: checkpatch.conf: new file
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 ) Change subject: checkpatch.conf: new file ...................................................................... checkpatch.conf: new file Disable spacing and open brace checks, as this repository follows a different code style. If needed, the checkpatch file can be extended with other checks: * get the check name from the linter output, e.g. SPACING in: firmware/ice40-riscv/icE1usb/fw_app.c:155: ERROR:SPACING: spaces required around that '=' (ctx:VxV) * add a new "--ignore NAME" line to the file Related: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26841 Related: OS#5399 Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 --- A .checkpatch.conf 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/27/26927/1 diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..20c0832 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1,2 @@ +--ignore OPEN_BRACE +--ignore SPACING -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 Gerrit-Change-Number: 26927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-MessageType: newchange
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 ) Change subject: checkpatch.conf: new file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 Gerrit-Change-Number: 26927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jan 2022 16:44:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Attention is currently required from: osmith. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 ) Change subject: checkpatch.conf: new file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 Gerrit-Change-Number: 26927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jan 2022 16:46:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 ) Change subject: checkpatch.conf: new file ...................................................................... checkpatch.conf: new file Disable spacing and open brace checks, as this repository follows a different code style. If needed, the checkpatch file can be extended with other checks: * get the check name from the linter output, e.g. SPACING in: firmware/ice40-riscv/icE1usb/fw_app.c:155: ERROR:SPACING: spaces required around that '=' (ctx:VxV) * add a new "--ignore NAME" line to the file Related: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26841 Related: OS#5399 Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 --- A .checkpatch.conf 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved tnt: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..20c0832 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1,2 @@ +--ignore OPEN_BRACE +--ignore SPACING -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I4d2cf2eb698b8f4e54f04e62e4dbbc37146daf88 Gerrit-Change-Number: 26927 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-MessageType: merged
participants (3)
-
laforge -
osmith -
tnt