Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email ) Change subject: Prevent poll() in select.c to timeout too early ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/35672/comment/3521b26d_5e5f8689 PS1, Line 11: Note that poll() has a granularity of 1 millisecond. ... while `select()` has a granularity of microseconds, according to the man page. File src/core/timer.c: https://gerrit.osmocom.org/c/libosmocore/+/35672/comment/c4d06513_d5da1e09 PS1, Line 199: nearest_ms += (nearest_p->tv_usec + 999) / 1000; Just curious: in which project did you find timers less than 1 ms? BTW, this change has a side effect: * 0.2 ms becomes 1 ms -- fine, as expected; * 1.2 ms becomes 2 ms -- probably not so nice. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I79de77c79af4d50d1eb9ca0c5417123ff760dca3 Gerrit-Change-Number: 35672 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Wed, 24 Jan 2024 18:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment