Change in osmo-msc[master]: Make esme struct shared
Attention is currently required from: neels, laforge, pespin, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 21: (3 comments) Patchset: PS21: Added comments to clarify struct difference as requested. File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f87ea8e5_12bae3a1 PS21, Line 14: esme
You marked my comment as resolved without responding. […] Done
File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/8a622463_205d5419 PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \
struct gsm_network contains opaque pointers to vlr_instance, that shouldn't pull in libvlr as depend […] I'm pretty sure it's possible to make it work - I hadn't tried to dig in this direction since it's outside of the scope for this ticket. Given that this is internal library which isn't actually installed I don't think it matters. Feel free to create a separate ticket and pull me in.
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 21 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 13:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: msuraev <msuraev@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
msuraev