Attention is currently required from: Hoernchen, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30337 )
Change subject: mobile: integrate GAPK based audio (voice) I/O support
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
The question is what "suffices" vs the
effort. […]
Done
File src/host/layer23/src/mobile/gapk_io.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/2b11fcb0_e1488491
PS5, Line 512: /* Serves both TCH frame I/O buffers */
both TCH you mean TCH/H and TCH/F here?
I mean
both Uplink and Downlink. Clarified in the new patchset.
https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/31dfc44c_79dfaa69
PS5, Line 528: ll
using llist_count() would probably be more easy to
read/understand rather than open-coding it by han […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9
Gerrit-Change-Number: 30337
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <axilirator(a)gmail.com>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment