[S] Change in osmo-bsc[master]: abis_rsl: Separate rach expiry delay from radio link timeout
Attention is currently required from: matanp. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Separate rach expiry delay from radio link timeout ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/c3fcd7ac_ea05c0ef PS3, Line 7: abis_rsl: Separate rach expiry delay from radio link timeout Please elaborate more why a separate parameter is needed (here in COMMIT_MSG). File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/5b3e3474_397dda40 PS3, Line 777: expiry timeout Let's combine it into a single command item `expiry-timeout`. https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/9e726999_a8844337 PS3, Line 4532: vty_out(vty, " rach max-delay %u%s", bts->rach_max_delay, VTY_NEWLINE); You're missing to print `rach expiry-timeout` here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iff7266672dd8bc9ce2b34b0478d98fb70691f425 Gerrit-Change-Number: 35475 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: matanp <matan1008@gmail.com> Gerrit-Comment-Date: Sun, 31 Dec 2023 21:33:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (1)
-
fixeria