Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30375 )
Change subject: trau_sync: Add the V.110 sync pattern
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/trau/trau_sync.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/30375/comment/7847b092_2254a65e
PS2, Line 5: enum osmo_tray_sync_pat_id {
can't do in a backwards compatible way. It's
part of public API and osmo-mgw uses it. […]
I'd do #define
osmo_tray_sync_pat_id osmo_trau_sync_pat_id for backward compat and change the name.
Let's not keep typos in API further in the future.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30375
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8
Gerrit-Change-Number: 30375
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 30 Nov 2022 17:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment