Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33374 ) Change subject: Differentiate between T3192 and T3193 ...................................................................... Patch Set 1: (3 comments) File src/tbf_dl_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/33374/comment/588032dd_46025cd5 PS1, Line 267: wil

will Ack

https://gerrit.osmocom.org/c/osmo-pcu/+/33374/comment/d922a72e_b7b9c414 PS1, Line 268: imtil

until Ack

https://gerrit.osmocom.org/c/osmo-pcu/+/33374/comment/43aaf439_7170a48f PS1, Line 303: LOGPTBF(ctx->tbf, LOGL_DEBUG, "Waiting %lu sec. %lu microsec (T3193 - T3192) [REUSE TFI]\n",

not that important, but how about: […] you'd have to add %07lu or alike, and since other timers around are already in this same format I'm keeping this one.

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7421342461bf159d945651037e6fe690f88c6fae Gerrit-Change-Number: 33374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 09:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Gerrit-MessageType: comment