Attention is currently required from: jolly, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33297 ) Change subject: ASCI: Add Notification CHannel (NCH) support ...................................................................... Patch Set 7: (2 comments) File include/osmo-bts/bts.h: https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/9be843af_248d0537 PS7, Line 413: int is_nch_res, int is_ag_res); sounds like these are bools? File tests/agch/agch_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/b6c546a3_3205de66 PS7, Line 162: rc = bts_ccch_copy_msg(bts, out_buf, &g_time, 0, is_agch); false -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa Gerrit-Change-Number: 33297 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:56:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment