Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email )

Change subject: osmo-bts-trx: reset BTS GSM time on clock (re)start ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42850/comment/a40f2d0c_682b1c90?usp=... : PS1, Line 499: gsm_fn2gsmtime(&bts->gsm_time, 0);

Don't we have the same problem on other BTS models?

Probably. But the problem is that only osmo-bts-trx has an explicit epoch hook `trx_sched_clock_started()` called on `POWERON`, while the others don't expose an equivalent "clock (re)started" signal. And honestly, I don't even know if other models reset their clock/time (TDMA Fn) after power-cycling the DSP.

Shouldn't this be put in some more generic code path?

Generic path would likely be `l1sap_info_time_ind()` in `l1sap.c`. But at this level there exists no signal/primitive about the clock state. We don't even know if the L1 is powered on or not...