[S] Change in osmo-bsc[master]: ASCI: Fix uninitialized values in vgcs_fsm.c, found by gcc 13.1.1.202...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029?usp=email ) Change subject: ASCI: Fix uninitialized values in vgcs_fsm.c, found by gcc 13.1.1.20230714 ...................................................................... Patch Set 3: (2 comments) File src/osmo-bsc/vgcs_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/cc6ee01b_c721e1bc PS1, Line 1083: struct gsm_lchan *lchan;
this also doesn't look like a fix for a warning, but an actual random-memory-dererference bug. Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/1228a5da_66f61062 PS1, Line 542: if (!conn->vgcs_call.fi) { : cause = GSM0808_CAUSE_INCORRECT_VALUE; : goto reject; : }
this doesn't look like a fix for a compiler warning, but an actual bugfix where prior to this patch […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 Gerrit-Change-Number: 34029 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 16:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment
participants (1)
-
laforge