[S] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated - gerrit-log

2 Jul 2026


      Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email )
Change subject: common: stop buffering UL measurements when SACCH is deactivated
......................................................................
Patch Set 3:
(1 comment)
File tests/meas/meas_test.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/4acad447_7fd73876?usp=... :
PS3, Line 71: 	lchan->ul_sacch_active = true;
...
why is this set to true here instead of false? […]
Because the testcases actually use this function as an initializer, not as a shutdown cleanup helper. Note that above this function changes the lchan state to active.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7
Gerrit-Change-Number: 42911
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 02 Jul 2026 20:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de