[L] Change in libosmo-abis[master]: ipaccess: Convert BSC OML & RSL link to use stream_srv
Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email ) Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv ...................................................................... Patch Set 4: (4 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/9725326f_38698b38?... : PS4, Line 14: ABI
You're removing a symbol, so it's actually API breakage, not ABI. Done
File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/bc7775b8_66a7bad7?... : PS4, Line 387: ballback
callback Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/9f166264_8add7b63?... : PS4, Line 470: default:
maybe put a log msg here? Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/d351a780_9695c073?... : PS4, Line 705: /* PESPIN: TODO: use osmo_stream_srv_send() instead */
did you leave this TODO intentionally? Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232 Gerrit-Change-Number: 38983 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 12:00:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
participants (1)
-
pespin