Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email ) Change subject: isdn: add a lookup table with E1/E2/E3 bits from Table 5/V.110 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Sounds a bit overkill taking into account they could be stored in 1 byte per entry instead of 3, and the macros could do bitwise operations to compare and set. What do you think? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d2f8e250df31c233a2741163113dc07515409ae Gerrit-Change-Number: 35587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jan 2024 19:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment