Attention is currently required from: fixeria, laforge, neels, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 27: (3 comments) File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/c4f724f8_8b62d2bd?u... : PS25, Line 44: const int msgLen = 4096;

Replaced it with MAX_LOG_SIZE Done

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/dd2ac945_1c490df7?u... : PS25, Line 47: char subsys_buf[16];

Thanks for the note. You’re right: the 16-byte limit comes from the GSMTAP on-wire header. […] Done

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/7b27a153_d93dddad?u... : PS25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0';

Thanks for pointing this out, fixed. Done

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 27 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 11:31:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp@gmail.com>