Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28210 ) Change subject: fix rare segfault in MGCP client handling ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28210/comment/c3db6d5d_40a26602 PS1, Line 134: gscon_forget_mgw_endpoint_ci(conn, ci); wouldn't it make sense to call osmo_mgcpc_ep_ci_dlcx(ci); inside gscon_forget_mgw_endpoint_ci() before setting conn->assignment.created_ci_for_msc to NULL? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If89610020f47fd6517081dd11b83911b043bd0f1 Gerrit-Change-Number: 28210 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Tue, 31 May 2022 08:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment