Change in osmo-e1d[master]: build: Increase warnings
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26807 ) Change subject: build: Increase warnings ...................................................................... build: Increase warnings Go with -Wextra but removing some of the obnoxious options it brings with it. Signed-off-by: Sylvain Munaut <tnt@246tNt.com> Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/07/26807/1 diff --git a/src/Makefile.am b/src/Makefile.am index 74ade7d..f4af9f2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -4,7 +4,7 @@ LIBVERSION=1:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -AM_CFLAGS=-Wall -Wno-unused-result $(LIBOSMOCORE_CFLAGS) \ +AM_CFLAGS=-Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-result $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) $(LIBOSMOUSB_CFLAGS) $(LIBUSB_CFLAGS) lib_LTLIBRARIES = libosmo-e1d.la -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a Gerrit-Change-Number: 26807 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt@246tNt.com> Gerrit-MessageType: newchange
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26807 ) Change subject: build: Increase warnings ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a Gerrit-Change-Number: 26807 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt@246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sun, 09 Jan 2022 21:58:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26807 ) Change subject: build: Increase warnings ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a Gerrit-Change-Number: 26807 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt@246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: deleteVote
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26807 ) Change subject: build: Increase warnings ...................................................................... build: Increase warnings Go with -Wextra but removing some of the obnoxious options it brings with it. Signed-off-by: Sylvain Munaut <tnt@246tNt.com> Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/src/Makefile.am b/src/Makefile.am index 74ade7d..f4af9f2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -4,7 +4,7 @@ LIBVERSION=1:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -AM_CFLAGS=-Wall -Wno-unused-result $(LIBOSMOCORE_CFLAGS) \ +AM_CFLAGS=-Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-result $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) $(LIBOSMOUSB_CFLAGS) $(LIBUSB_CFLAGS) lib_LTLIBRARIES = libosmo-e1d.la -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaafd35ba39e272d5900b31b14d2651e0ecb8a84a Gerrit-Change-Number: 26807 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt@246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged
participants (2)
-
laforge -
tnt