Attention is currently required from: Andrei G.

pespin has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/libosmocore/+/43572?usp=email )

Change subject: core/stats_tcp: declare struct osmo_fd in header ......................................................................

Patch Set 1:

(2 comments)

File include/osmocom/core/stats_tcp.h:

https://gerrit.osmocom.org/c/libosmocore/+/43572/comment/e185fefd_4c76e908?u... : PS1, Line 14: /* The prototypes below name struct osmo_fd without declaring it. A translation Please drop the whole comment, if we had to add this paragraph for each forward declaration we'd have an entire bible by now.

https://gerrit.osmocom.org/c/libosmocore/+/43572/comment/732e751f_6900c635?u... : PS1, Line 18: struct osmo_fd; We usually place these forward declarations up in the file, eg. immediatelly after where you'd put an include.