Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email ) Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name ...................................................................... Patch Set 2: (2 comments) File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/34960/comment/7093488e_34e7c377 PS2, Line 50: is_a_number(reader_number):

Looks like you always expect `reader_number` to be a string: either with the reader number or a rege […] you are right. The point is that the only current caller always passes a string, and that might be an integer or something else. I forgot that a future other caller might actually pas an int.

https://gerrit.osmocom.org/c/pysim/+/34960/comment/69384e61_7df80510 PS2, Line 132: '--pcsc-device

(just a suggestion) maybe keep this argument unchanged (and keep it as `int`), and add another one l […] I thought about this, but sadly the constructor doesn't get passed the full 'opts' from the argparser, so adding arguments requires also modifications elsewhere. I'll have a look and try to clean this up.

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/34960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I983f19c6741904c1adf27749c9801b44a03a5d78 Gerrit-Change-Number: 34960 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Sat, 04 Nov 2023 15:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment