Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31102
)
Change subject: pcuif_proto: add indication to communicate E1 parameters
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31102/comment/d1b7b528_0bfe5991
PS1, Line 263: uint8_t pdch_trx_no;
we use trx_nr and ts_nr everywhere afaict, better use
same names.
makes sense, but the prefix should stay, since we need to distinguish
between e1 timeslots and pdch timeslots which are two different things.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31102
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301
Gerrit-Change-Number: 31102
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 12:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment